[#DOTCMS-3916] Get an IllegalStateException when doing a redirect from a widget

dotCMS

Get an IllegalStateException when doing a redirect from a widget

Created: February 12, 2010 4:18 AM Updated: July 27, 2010 8:37 AM

Component/s:

a. Unknown

Affects Version/s:

None

Fix Version/s:

1.9

Time Tracking:

Original Estimate:

Not Specified

Remaining Estimate:

0 minutes

Time Spent:

1 day, 7 hours

Description

« Hide

Happens when the redirect is done from a ViewTool or directly from Velocity. Happens both when ViewTool is application and request scope. It seems to happen because response.isCommitted() returns true.

All

Comments

Work Log

Change History

Subversion Commits

FishEye

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Maria Bouza - February 12, 2010 11:50 AM

Hi Paolo,

These bugs need to be reported to the dotCMS project, not dotCMS Plugins.

thanks
Maria

Change by Maria Bouza - February 12, 2010 11:50 AM
Field	Original Value	New Value
Project	dotCMS Plugins [ 5803983 ]	dotCMS [ 5803855 ]
Key	DOTCMSPLUGIN-45	~~DOTCMS-3916~~
Workflow	jira [ 5890232 ]	dotCMS EE and OS WorkFlow1 [ 5890245 ]
Component/s		a. Unknown [ 5804718 ]
Component/s	Konakart [ 5804715 ]

Change by Maria Bouza - February 12, 2010 11:57 AM
Assignee	Maria Bouza [ maria ]	Jason Tesser [ jason.tesser@dotmarketing.com ]

Change by Jason Tesser - February 12, 2010 11:59 AM
Fix Version/s		1.9 [ 10039 ]

Change by Jason Tesser - March 10, 2010 8:28 AM
Workflow	dotCMS EE and OS WorkFlow1 [ 5890245 ]	dotCMS Workflow [ 5894174 ]

[ Permlink | « Hide ]

Jason Tesser - March 25, 2010 8:45 AM

So the final solution here is to add an optional field to the widget. Meaning when a widget is created it will get this field like it gets the Widget Code etc... which the page services will execute.

A few things
1. We need a startup task to update the field for all current widgets.
2. In the PageServices try to use a set to $_dummy so that it doesn't spit out any output.

This should be easy in Page Services as we already hit the multitree for content. We just need to know which content is a widget and if it is then execute.

Test the solution with a widget that has a condition to redirect.

Change by Jason Tesser - March 25, 2010 8:45 AM
Priority	Blocker [ 1 ]	Major [ 3 ]
Assignee	Jason Tesser [ jason.tesser@dotmarketing.com ]	Sebastian Torres [ sebastian.torres@dotcms.org ]

Change by Sebastian Torres - March 26, 2010 5:02 PM
Remaining Estimate		0 minutes [ 0 ]
Time Spent		1 hour [ 3600 ]

[ Permlink | « Hide ]

Jason Tesser - March 29, 2010 4:16 PM

cal the field Pre-Execute

Change by Sebastian Torres - March 29, 2010 5:48 PM
Time Spent	1 hour [ 3600 ]	3 hours [ 10800 ]

Change by Sebastian Torres - March 30, 2010 5:40 PM
Time Spent	3 hours [ 10800 ]	7 hours [ 25200 ]

Repository	Revision	Date	User	Message
dotcms.org	#22020	Mon Apr 05 17:41:52 EDT 2010	sebastian.torres	http://jira.dotmarketing.net/browse/DOTCMS-3916
				Files Changed
				MODIFY /trunk/dotCMS/starter.zip MODIFY /trunk/src/com/dotmarketing/services/PageServices.java ADD /trunk/src/com/dotmarketing/startup/runonce/Task00410AddPreExecuteFieldToWidgets.java MODIFY /trunk/src/com/dotmarketing/services/ContentletMapServices.java MODIFY /trunk/src/com/dotmarketing/services/ContentletServices.java MODIFY /trunk/src/com/dotmarketing/portlets/widget/business/WidgetAPI.java MODIFY /trunk/src/com/dotmarketing/portlets/widget/business/WidgetAPIImpl.java

Change by Sebastian Torres - April 05, 2010 5:47 PM
Time Spent	7 hours [ 25200 ]	1 day, 3 hours [ 39600 ]

Change by Sebastian Torres - April 05, 2010 5:47 PM
Resolution		IN QA [ 10 ]
Assignee	Sebastian Torres [ sebastian.torres@dotcms.org ]	Testing User [ testing@dotcms.org ]
Status	Open [ 1 ]	Ready for Code Review [ 10006 ]

[ Permlink | « Hide ]

Jason Tesser - April 08, 2010 3:27 PM

David is right I think this needs to work in edit mode.

Change by Jason Tesser - April 08, 2010 3:27 PM
Assignee	Testing User [ testing@dotcms.org ]	Sebastian Torres [ sebastian.torres@dotcms.org ]

Change by Jason Tesser - April 08, 2010 3:27 PM
Resolution	IN QA [ 10 ]
Status	Ready for Code Review [ 10006 ]	Open [ 1 ]
Assignee	Sebastian Torres [ sebastian.torres@dotcms.org ]	Jason Tesser [ jason.tesser@dotmarketing.com ]

Change by Jason Tesser - April 08, 2010 3:27 PM
Assignee	Jason Tesser [ jason.tesser@dotmarketing.com ]	Sebastian Torres [ sebastian.torres@dotcms.org ]

Change by Sebastian Torres - April 09, 2010 5:16 PM
Time Spent	1 day, 3 hours [ 39600 ]	1 day, 4 hours [ 43200 ]

Change by Sebastian Torres - April 13, 2010 6:03 PM
Time Spent	1 day, 4 hours [ 43200 ]	1 day, 5 hours [ 46800 ]

Repository	Revision	Date	User	Message
dotcms.org	#22228	Tue Apr 20 11:04:01 EDT 2010	sebastian.torres	http://jira.dotmarketing.net/browse/DOTCMS-3916
				Files Changed
				MODIFY /trunk/src/com/dotmarketing/velocity/VelocityServlet.java

Change by Sebastian Torres - April 20, 2010 11:10 AM
Time Spent	1 day, 5 hours [ 46800 ]	1 day, 7 hours [ 54000 ]

Change by Sebastian Torres - April 20, 2010 11:11 AM
Resolution		IN QA [ 10 ]
Assignee	Sebastian Torres [ sebastian.torres@dotcms.org ]	Testing User [ testing@dotcms.org ]
Status	Open [ 1 ]	Ready for Code Review [ 10006 ]

Change by Jason Tesser - April 20, 2010 11:35 AM
Status	Ready for Code Review [ 10006 ]	Code Reviewed [ 10005 ]

Change by Jason Tesser - July 27, 2010 8:37 AM
Resolution	IN QA [ 10 ]	Released [ 9 ]
Status	Code Reviewed [ 10005 ]	Released [ 10002 ]

Change by Jason Tesser - July 29, 2010 8:28 AM
Workflow	dotCMS Workflow [ 5894174 ]	dotCMS WF [ 5900622 ]

Change by Jason Tesser - August 27, 2010 8:48 AM
Workflow	dotCMS WF [ 5900622 ]	dotCMS Workflow [ 5905617 ]

Change by Jason Tesser - August 30, 2010 8:04 AM
Workflow	dotCMS Workflow [ 5905617 ]	dotCMS WF [ 5910180 ]